Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Disallow promoting preview deployments to production #11363

Merged
merged 7 commits into from
Apr 9, 2024

Conversation

trek
Copy link
Contributor

@trek trek commented Apr 1, 2024

Blocks preview deployments from being directly promoted. This relies on a new API version bump.

Copied the warning text from the UI:
CleanShot 2024-04-01 at 11 04 00@2x

This is a breaking change and will require a major version bump. Please don't merge until we're ready.

@trek trek added the semver: major PR contains breaking changes label Apr 1, 2024
Copy link

changeset-bot bot commented Apr 1, 2024

🦋 Changeset detected

Latest commit: 957bd26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vercel Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@EndangeredMassa
Copy link
Contributor

vercel@33.7.0 had the deprecation warning. So, it's safe to merge this and release a new major.

@EndangeredMassa EndangeredMassa added the pr: automerge Automatically merge the PR when checks pass label Apr 9, 2024
@kodiakhq kodiakhq bot merged commit 4e416d7 into main Apr 9, 2024
7 of 8 checks passed
@kodiakhq kodiakhq bot deleted the trek/zero-1707-change-cli-to-use-v10-for-promotions branch April 9, 2024 22:02
TooTallNate added a commit that referenced this pull request Apr 10, 2024
…11363)"

This reverts commit 4e416d7.

It was erroneously merged by Kodiak with failing unit tests.
@TooTallNate
Copy link
Member

Reverting this due to failing unit tests: #11410

kodiakhq bot pushed a commit that referenced this pull request Apr 10, 2024
…11363)" (#11410)

This reverts commit 4e416d7.

It was erroneously merged by Kodiak with failing unit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Automatically merge the PR when checks pass semver: major PR contains breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants