-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[next] Update react version in next fixtures #11566
Conversation
🦋 Changeset detectedLatest commit: f3526ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
"react": "experimental", | ||
"react-dom": "experimental" | ||
"react": "19.0.0-beta-4508873393-20240430", | ||
"react-dom": "19.0.0-beta-4508873393-20240430" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess these can stay experimental
since they never matched the peer dependency range to begin with?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was using the tag bypassing the peer dep check maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't because the peer dep check is done on the resolved version not on the tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm will leave locked then to be safe/for consistency
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## vercel@34.1.10 ### Patch Changes - Updated dependencies \[[`119f80e96`](119f80e), [`11584b0e9`](11584b0), [`3023122d4`](3023122), [`0e774b6be`](0e774b6)]: - @vercel/next@4.2.9 - @vercel/static-build@2.5.4 ## @vercel/next@4.2.9 ### Patch Changes - Support incremental partial prerendering ([#11560](#11560)) - ensure `.action` outputs are created for edge functions ([#11568](#11568)) - ([#11566](#11566)) ## @vercel/static-build@2.5.4 ### Patch Changes - Fix `Cannot read properties of null` error ([#11559](#11559)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
We are locking the peerDependency to react v19 beta on canary so we need to update these fixtures to tolerate that.
x-ref: slack thread
x-ref: vercel/next.js#65058