[next]: ensure unmatched action rewrites are routed to correct handler #11686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 37f13a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ztanner
requested review from
TooTallNate,
EndangeredMassa,
trek,
onsclom,
jeffsee55,
erikareads,
timneutkens,
ijjk,
huozhi and
Ethan-Arrowood
as code owners
ztanner
force-pushed
the
fix/unmatched-action-rewrites
branch
from
5896e13
to
df41138
Compare
ijjk
reviewed
Jun 3, 2024
ijjk
approved these changes
Jun 3, 2024
Merged
ztanner
pushed a commit
that referenced
this pull request
Jun 4, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## vercel@34.2.5 ### Patch Changes - Adds a route for the `.rsc` pathname as well when app has ppr enabled but not all routes. ([#11681](#11681)) - Updated dependencies \[[`7457767a7`](7457767), [`4337ea065`](4337ea0)]: - @vercel/next@4.2.15 ## @vercel/fs-detectors@5.2.4 ### Patch Changes - Add support for detecting Turborepo 2 ([#11680](#11680)) ## @vercel/next@4.2.15 ### Patch Changes - ensure unmatched action rewrites are routed to correct handler ([#11686](#11686)) - Adds a route for the `.rsc` pathname as well when app has ppr enabled but not all routes. ([#11681](#11681)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User defined rewrites are "normalized" so that our internal rewrites are still properly handled. Before normalizing these rewrites, the Next.js builder will attempt to match server action requests to a
.actionvariant. Then the user-defined rewrites flow through the afterFiles normalization (this part) so that when we add.actionin the builder, we don't drop the suffix.But this normalization can lead to a malformed
dest. e.g., if I had rewrite like this:The builder would go through this flow on an action request to
/greedy-rewrite/static:.actionoutput, so/greedy-rewrite/static->/greedy-rewrite/static.actiondestof/static/$1will become/static/$1$rscsuff/greedy-rewrite/static.action->/greedy-rewrite/static/.actionstatic/.actionis not a valid output, so it'll 404 and the action will break.Existing handling exists for
.rscoutputs for a similar reason, but only on the index route. I added a similar fix for this in #11688.