[node] ignore shouldAddHelpers when exporting a server to match production
#11738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuiiBz
requested review from
TooTallNate,
EndangeredMassa,
trek,
onsclom,
jeffsee55,
erikareads and
Kikobeats
as code owners
🦋 Changeset detectedLatest commit: 36ce6f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
trek
previously approved these changes
Jun 18, 2024
TooTallNate
reviewed
Jun 18, 2024
trek
approved these changes
Jun 20, 2024
…n-vercel-cli-when-using-a-server
QuiiBz
deleted the
tomlienard/ec-2223-ignore-shouldaddhelpers-in-vercel-cli-when-using-a-server
branch
Merged
EndangeredMassa
pushed a commit
that referenced
this pull request
Jun 25, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/node@3.2.0 ### Minor Changes - Ignore `shouldAddHelpers` when exporting a server to match production ([#11738](#11738)) ### Patch Changes - Update undici dep to address vulnerabilities ([#11749](#11749)) ## vercel@34.2.8 ### Patch Changes - Updated dependencies \[[`fd069f184`](fd069f1), [`8ae40d096`](8ae40d0), [`f0d6acaa0`](f0d6aca), [`e33756494`](e337564), [`dcb7fa5f9`](dcb7fa5)]: - @vercel/node@3.2.0 - @vercel/next@4.2.18 - @vercel/remix-builder@2.1.8 ## @vercel/next@4.2.18 ### Patch Changes - Allow app router prerender functions to use streaming ([#11745](#11745)) - Add experimental preload flag ([#11753](#11753)) ## @vercel/remix-builder@2.1.8 ### Patch Changes - Add opt-in env var to use native Fetch polyfills ([#11748](#11748)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to https://x.com/maggiepint/status/1801975947421442137, we have a difference between production and development (
vc dev) regardingshouldAddHelpers:That means we set/override things like
req.bodyin development, but don't in production. Changing the logic in production can trigger unexpected behaviors and break existing applications, so we should instead fix the CLI to have the same behavior as production.