[cli] allow prerender to stream #11745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6070d67 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
craigandrews
requested review from
TooTallNate,
EndangeredMassa,
trek,
onsclom,
jeffsee55,
erikareads,
timneutkens,
ijjk,
ztanner,
huozhi and
Ethan-Arrowood
as code owners
ijjk
reviewed
Jun 18, 2024
ijjk
approved these changes
Jun 18, 2024
craigandrews
deleted the
craigandrews/do-not-block-streaming-for-prerender
branch
Merged
TooTallNate
added a commit
that referenced
this pull request
Jun 19, 2024
TooTallNate
added a commit
that referenced
this pull request
Jun 19, 2024
The changeset file from #11745 incorrectly references the `vercel` package, but the code change is in `@vercel/next`. The changeset file needs to reference that package otherwise a new version of `@vercel/next` will not be published to include the change from the PR.
EndangeredMassa
pushed a commit
that referenced
this pull request
Jun 25, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/node@3.2.0 ### Minor Changes - Ignore `shouldAddHelpers` when exporting a server to match production ([#11738](#11738)) ### Patch Changes - Update undici dep to address vulnerabilities ([#11749](#11749)) ## vercel@34.2.8 ### Patch Changes - Updated dependencies \[[`fd069f184`](fd069f1), [`8ae40d096`](8ae40d0), [`f0d6acaa0`](f0d6aca), [`e33756494`](e337564), [`dcb7fa5f9`](dcb7fa5)]: - @vercel/node@3.2.0 - @vercel/next@4.2.18 - @vercel/remix-builder@2.1.8 ## @vercel/next@4.2.18 ### Patch Changes - Allow app router prerender functions to use streaming ([#11745](#11745)) - Add experimental preload flag ([#11753](#11753)) ## @vercel/remix-builder@2.1.8 ### Patch Changes - Add opt-in env var to use native Fetch polyfills ([#11748](#11748)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow all app router lambdas to use streaming, including prerender and experimental PPR.
Practically speaking this is a no-op at the moment;
api-buildshas a feature-flagged check to ensure any prerender function will not stream. It is effectively a duplicate of the check that this PR removes.This is the check in
api-builds: https://github.com/vercel/api/blob/987de85d6a38a34f717cd1372826cbaf6113dd7d/services/api-builds/src/endpoints/post-lambda.ts#L273