Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped update-check to the latest version #1354

Merged
merged 1 commit into from May 18, 2018
Merged

Bumped update-check to the latest version #1354

merged 1 commit into from May 18, 2018

Conversation

leo
Copy link
Contributor

@leo leo commented May 18, 2018

We recently saw a few 405 errors (only on the Canary channel) that made an error message show up while checking for updates (the error came from npm).

As it turns out, update-check is not at the latest version in here. This fixes it!

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@leo leo removed the request for review from javivelasco May 18, 2018 12:05
@leo leo merged commit 3cb4a9c into canary May 18, 2018
@leo leo deleted the ensure-update-check branch May 18, 2018 12:06
leo added a commit that referenced this pull request May 18, 2018
rauchg pushed a commit that referenced this pull request May 21, 2018
* Strip quotes from Dockerfile labels

* remove console.log

* add test

* issue normal cert for nested subdomain (#1344)

* Prefer HTTP challenge for regular certs

* 12.0.0-canary.31

* Update non-existing team test

* 12.0.0-canary.32

* Bumped `update-check` to the latest version (#1354)

* 12.0.0-canary.33

* Strip quotes from Dockerfile labels

* remove console.log

* add test
leo pushed a commit that referenced this pull request May 24, 2018
* Strip quotes from Dockerfile labels

* remove console.log

* add test

* issue normal cert for nested subdomain (#1344)

* Prefer HTTP challenge for regular certs

* 12.0.0-canary.31

* Update non-existing team test

* 12.0.0-canary.32

* Bumped `update-check` to the latest version (#1354)

* 12.0.0-canary.33

* Strip quotes from Dockerfile labels

* remove console.log

* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants