Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade @zeit/ncc #1725

Merged
merged 2 commits into from Dec 6, 2018
Merged

Downgrade @zeit/ncc #1725

merged 2 commits into from Dec 6, 2018

Conversation

leo
Copy link
Contributor

@leo leo commented Dec 6, 2018

This fixes this error:

image

@leo leo added the enhancement label Dec 6, 2018
@leo leo requested a review from joecohens December 6, 2018 22:29
@joecohens
Copy link
Contributor

@leo are you missing the package.json change?

@leo
Copy link
Contributor Author

leo commented Dec 6, 2018

@joecohens Yea, I copied over from the wrong location. Fixed!

@leo leo merged commit c6a16a0 into canary Dec 6, 2018
@leo leo deleted the downgrade-ncc branch December 6, 2018 22:31
leo added a commit that referenced this pull request Dec 6, 2018
@leo
Downgrade @zeit/ncc (#1725)
869375a 
* Downgrade `@zeit/ncc`

* Fixed package.json
@codecov-io
Copy link

Codecov Report

Merging #1725 into canary will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           canary    #1725   +/-   ##
=======================================
  Coverage   71.21%   71.21%           
=======================================
  Files          12       12           
  Lines         337      337           
=======================================
  Hits          240      240           
  Misses         97       97

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16c0a93...d01498a. Read the comment docs.

@leo leo mentioned this pull request Dec 6, 2018
Closed
javivelasco added a commit that referenced this pull request Dec 7, 2018
@javivelasco
Merge branch 'canary' into new-domains-api
6983d80 
* canary:
  13.0.0-canary.21
  Fixed even more Sentry errors (#1726)
  13.0.0-canary.20
  Downgrade `@zeit/ncc` (#1725)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joecohens joecohens joecohens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leo @joecohens @codecov-io