[now dev] Add support for Builder "subscriptions" #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the builder has a `subscribe()` function, then the initial builds are not run and instead an array of "subscriptions" is created. When an HTTP request comes in that matches one of the subscription patterns, then this builder will be actually be executed.
Codecov Report
@@ Coverage Diff @@
## canary #2071 +/- ##
=========================================
+ Coverage 4.5% 4.51% +<.01%
=========================================
Files 243 243
Lines 8542 8557 +15
Branches 868 871 +3
=========================================
+ Hits 385 386 +1
- Misses 8140 8154 +14
Partials 17 17
Continue to review full report at Codecov.
|
amio
approved these changes
Apr 3, 2019
leo
approved these changes
Apr 3, 2019
leo
pushed a commit
that referenced
this pull request
Apr 5, 2019
If the builder has a `subscribe()` function, then the initial builds are not run and instead an array of "subscriptions" is created. When an HTTP request comes in that matches one of the subscription patterns, then this builder will be actually be executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the builder has a
subscribe()function, then the initial builds are not run and instead an array of "subscriptions" is created. When an HTTP request comes in that matches one of the subscription patterns, then this builder will be actually be executed.