resolves parameters in headers location #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamli
changed the title
|
@TooTallNate not sure if it's ok to bump the canary version number in package.json. I was using it to see if my local |
This reverts commit 5857489.
styfle
reviewed
Apr 4, 2019
styfle
reviewed
Apr 4, 2019
Co-Authored-By: williamli <email@williamli.dev>
Codecov Report
@@ Coverage Diff @@
## canary #2095 +/- ##
=========================================
+ Coverage 4.5% 4.56% +0.06%
=========================================
Files 243 243
Lines 8575 8582 +7
Branches 876 878 +2
=========================================
+ Hits 386 392 +6
Misses 8172 8172
- Partials 17 18 +1
Continue to review full report at Codecov.
|
styfle
reviewed
Apr 4, 2019
|
|
|
@TooTallNate https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers |
…-parameters' into feature/now-dev-headers-location-parameters
|
@TooTallNate done |
TooTallNate
approved these changes
Apr 4, 2019
styfle
reviewed
Apr 4, 2019
TooTallNate
added a commit
that referenced
this pull request
Apr 4, 2019
This is a follow up to #2095 to move the `resolveRouteParameters()` funcrtion to the top-level and other slight optimizations like not re-parsing the URL multiple times.
TooTallNate
added a commit
that referenced
this pull request
Apr 4, 2019
* [now dev] Clean up `dev-router` a bit This is a follow up to #2095 to move the `resolveRouteParameters()` funcrtion to the top-level and other slight optimizations like not re-parsing the URL multiple times. * Remove unused `qs` import
leo
pushed a commit
that referenced
this pull request
Apr 5, 2019
* version bump (canary) * inject paramters into headers.Location fixes #2092 * refactored route parameter resolving function * Revert "version bump (canary)" This reverts commit 5857489. * Update src/commands/dev/lib/dev-router.ts Co-Authored-By: williamli <email@williamli.dev> * refactor headers resolution * try to resolve all parameters inside each child of headers
leo
pushed a commit
that referenced
this pull request
Apr 5, 2019
* [now dev] Clean up `dev-router` a bit This is a follow up to #2095 to move the `resolveRouteParameters()` funcrtion to the top-level and other slight optimizations like not re-parsing the URL multiple times. * Remove unused `qs` import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.