[now dev] Clean up dev-router a bit
#2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up to #2095 to move the `resolveRouteParameters()` funcrtion to the top-level and other slight optimizations like not re-parsing the URL multiple times.
Closed
Codecov Report
@@ Coverage Diff @@
## canary #2099 +/- ##
=========================================
- Coverage 4.55% 4.54% -0.01%
=========================================
Files 243 243
Lines 8589 8577 -12
Branches 878 875 -3
=========================================
- Hits 391 390 -1
+ Misses 8180 8170 -10
+ Partials 18 17 -1
Continue to review full report at Codecov.
|
styfle
approved these changes
Apr 4, 2019
leo
pushed a commit
that referenced
this pull request
Apr 5, 2019
* [now dev] Clean up `dev-router` a bit This is a follow up to #2095 to move the `resolveRouteParameters()` funcrtion to the top-level and other slight optimizations like not re-parsing the URL multiple times. * Remove unused `qs` import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #2095 to move the
resolveRouteParameters()function to the top-level and other slight optimizations like not re-parsing the URL multiple times.