[now dev] Add --listen / -l flag, deprecate --port / -p
#2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the default network interface that `now dev` binds to, in order to prevent operating system firewalls from showing a confirmation prompt in order to run. Fixes #2704.
styfle
approved these changes
Aug 7, 2019
TooTallNate
changed the title
--bind / -b flag--listen / -l flag
TooTallNate
changed the title
--listen / -l flag--listen / -l flag, deprecate --port / -p
Codecov Report
@@ Coverage Diff @@
## canary #2720 +/- ##
==========================================
+ Coverage 13.57% 13.71% +0.14%
==========================================
Files 261 262 +1
Lines 10536 10569 +33
Branches 1356 1366 +10
==========================================
+ Hits 1430 1450 +20
- Misses 8961 8970 +9
- Partials 145 149 +4
Continue to review full report at Codecov.
|
styfle
reviewed
Aug 9, 2019
styfle
approved these changes
Aug 9, 2019
TooTallNate
added a commit
that referenced
this pull request
Aug 9, 2019
Accidentally added in #2720.
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 9, 2019
Accidentally added in #2720.
AndyBitz
pushed a commit
that referenced
this pull request
Aug 20, 2019
* [now dev] Add `--bind` / `-b` flag This changes the default network interface that `now dev` binds to, in order to prevent operating system firewalls from showing a confirmation prompt in order to run. Fixes #2704. * Change to `--listen` * Default port 3000 * Fix unit * Fix `--port` * Use `-l` for integration tests * Add unit tests
AndyBitz
pushed a commit
that referenced
this pull request
Aug 20, 2019
Accidentally added in #2720.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates
--portin favor of a new--listenflag, which matches the behavior ofserve. This allows for binding to a specific network interface, as well as Unix socket files or Windows named pipes.