Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print HTTP status code upon API JSON parse errors #2727

Merged
merged 2 commits into from Aug 8, 2019
Merged

Print HTTP status code upon API JSON parse errors #2727

merged 2 commits into from Aug 8, 2019

Conversation

TooTallNate
Copy link
Member

Fixes #2681.

@TooTallNate TooTallNate requested a review from leo as a code owner August 7, 2019 20:27
@codecov-io
Copy link

codecov-io commented Aug 7, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (canary@718100f). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             canary    #2727   +/-   ##
=========================================
  Coverage          ?   13.61%           
=========================================
  Files             ?      261           
  Lines             ?    10505           
  Branches          ?     1345           
=========================================
  Hits              ?     1430           
  Misses            ?     8930           
  Partials          ?      145
Impacted Files Coverage Δ
src/util/index.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 718100f...08862a4. Read the comment docs.

@kodiakhq kodiakhq bot merged commit 9e961b4 into canary Aug 8, 2019
@kodiakhq kodiakhq bot deleted the update/api-error-print-http-status branch August 8, 2019 20:51
AndyBitz pushed a commit that referenced this pull request Aug 20, 2019
@TooTallNate @AndyBitz
Print HTTP status code upon API JSON parse errors (#2727)
0310678 
Fixes #2681.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@AndyBitz AndyBitz AndyBitz approved these changes

@leo leo Awaiting requested review from leo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Render status code when failing to parse JSON
4 participants
@TooTallNate @codecov-io @styfle @AndyBitz