Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CircleCI] Remove publish-stable and publish-canary steps #2957

Merged
merged 2 commits into from
Sep 4, 2019

Conversation

TooTallNate
Copy link
Member

Publishing to npm is now handled by GitHub Actions.

Aside from that, the Circle publishing was broken. See: https://circleci.com/gh/zeit/now/7213

Publishing to npm is now handled by GitHub Actions.

Aside from that, the Circle publishing was broken.
See: https://circleci.com/gh/zeit/now/7213
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 6e43c32 into canary Sep 4, 2019
@codecov-io
Copy link

Codecov Report

Merging #2957 into canary will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #2957      +/-   ##
==========================================
+ Coverage   11.23%   11.32%   +0.08%     
==========================================
  Files         267      267              
  Lines       10069    10079      +10     
  Branches     1310     1303       -7     
==========================================
+ Hits         1131     1141      +10     
- Misses       8847     8848       +1     
+ Partials       91       90       -1
Impacted Files Coverage Δ
src/util/dev/router.ts 82.69% <0%> (+4.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b6387b...6fc8167. Read the comment docs.

@kodiakhq kodiakhq bot deleted the remove/circle-ci-publish branch September 4, 2019 20:33
styfle pushed a commit that referenced this pull request Sep 17, 2019
Publishing to npm is now handled by GitHub Actions.

Aside from that, the Circle publishing was broken.
See: https://circleci.com/gh/zeit/now/7213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants