[now-client] Fix windows paths handling #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyBitz
reviewed
Sep 6, 2019
styfle
changed the title
styfle
reviewed
Sep 6, 2019
TooTallNate
reviewed
Sep 6, 2019
Codecov Report
@@ Coverage Diff @@
## canary #2974 +/- ##
==========================================
+ Coverage 13.28% 13.38% +0.09%
==========================================
Files 268 268
Lines 10321 10342 +21
Branches 1223 1218 -5
==========================================
+ Hits 1371 1384 +13
- Misses 8888 8896 +8
Partials 62 62
Continue to review full report at Codecov.
|
AndyBitz
approved these changes
Sep 7, 2019
rdev
added a commit
that referenced
this pull request
Sep 9, 2019
* Fix windows paths handling in now-client * Tweak windows paths handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures Windows path separators are handled properly (fixes #2972)