-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[now-cli] Render correct command for now ls $path_alias_url
#2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if you ran `now ls` with a URL for a path alias, then an error message `Cannot read property 'replace' of undefined` would occur. Now, a message is logged saying to instead run `now alias ls $url` which is the correct command to get path rules relevant to a path alias URL. > Found matching path alias: rules.domain.com > Please run `now alias ls rules.domain.com` instead Fixes #2987.
TooTallNate
added
automerge
triaged: bug
Issue or PR has been reviewed by a maintainer and work is being tracked
area: cli
labels
Sep 10, 2019
@TooTallNate Is it possible to add a test for this behavior? |
AndyBitz
approved these changes
Sep 11, 2019
Codecov Report
@@ Coverage Diff @@
## canary #2988 +/- ##
==========================================
- Coverage 13.37% 11.33% -2.05%
==========================================
Files 268 268
Lines 10344 10096 -248
Branches 1218 1306 +88
==========================================
- Hits 1384 1144 -240
+ Misses 8898 8862 -36
- Partials 62 90 +28
Continue to review full report at Codecov.
|
styfle
pushed a commit
that referenced
this pull request
Sep 17, 2019
Previously, if you ran `now ls` with a URL for a path alias, then an error message `Cannot read property 'replace' of undefined` would occur. Now, a message is logged saying to instead run `now alias ls $url` which is the correct command to get path rules relevant to a path alias URL. > Found matching path alias: rules.domain.com > Please run `now alias ls rules.domain.com` instead Fixes #2987.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you ran
now ls
with a URL for a path alias, then an error messageCannot read property 'replace' of undefined
would occur.Now, a message is logged saying to instead run
now alias ls $url
which is the correct command to get path rules relevant to a path alias URL.Fixes #2987.