[now-ruby] Use pre-installed ruby 2.5 #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## canary #2991 +/- ##
==========================================
- Coverage 13.27% 11.24% -2.03%
==========================================
Files 268 268
Lines 10329 10086 -243
Branches 1223 1313 +90
==========================================
- Hits 1371 1134 -237
+ Misses 8896 8861 -35
- Partials 62 91 +29
Continue to review full report at Codecov.
|
|
@nathancahill Oddly enough, this seemed to perform better in 376ffe0 than it did in cfa1d61 and tests pass for both. Now that the builder will share the same ruby installation for all builds, does GEM_HOME matter either way? |
TooTallNate
reviewed
Sep 11, 2019
TooTallNate
reviewed
Sep 11, 2019
TooTallNate
approved these changes
Sep 11, 2019
styfle
added a commit
that referenced
this pull request
Sep 17, 2019
* [now-ruby] Use pre-installed ruby 2.5 * Change GEM_HOME * Add polyfill for Node 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will improve performance of
@now/rubydeployments since it will not need to install ruby each time. We already have ruby 2.5 in the build environment so this PR makes the builder aware of that path.I am still installing the bundler to avoid the conflicting versions since ruby 2.6 is installed in the PATH.
Benchmark
cc @nathancahill
This also adds a polyfill for Node 10 to fix #2998