Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes script to PUBLISHING.md #3006

Merged
merged 2 commits into from Sep 12, 2019
Merged

Add release notes script to PUBLISHING.md #3006

merged 2 commits into from Sep 12, 2019

Conversation

styfle
Copy link
Member

@styfle styfle commented Sep 12, 2019

This script can be used every time we publish.

It obviously wont create a GitHub release but it can be used to generate the text to copy/pasta into a GitHub release.

This will work for canary or master, as long as we run it each time before lerna publishes.

It is the responsibility of the person publishing to select the proper tag, probably always use now@* for stable releases.

@codecov-io
Copy link

codecov-io commented Sep 12, 2019

Codecov Report

Merging #3006 into canary will increase coverage by 1.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           canary    #3006     +/-   ##
=========================================
+ Coverage   11.98%   13.28%   +1.3%     
=========================================
  Files         268      268             
  Lines       10189    10336    +147     
  Branches     1297     1223     -74     
=========================================
+ Hits         1221     1373    +152     
- Misses       8875     8901     +26     
+ Partials       93       62     -31
Impacted Files Coverage Δ
src/util/prefer-v2-deployment.ts 56.25% <0%> (-5.66%) ⬇️
src/util/projects/get-project-by-id-or-name.ts 25% <0%> (-3.58%) ⬇️
src/util/metrics.ts 70.58% <0%> (+2.4%) ⬆️
src/util/dev/builder-cache.ts 80.74% <0%> (+3.47%) ⬆️
src/util/dev/router.ts 82.69% <0%> (+4.12%) ⬆️
src/util/dev/builder.ts 77.41% <0%> (+4.34%) ⬆️
src/util/dev/yarn-installer.ts 90.74% <0%> (+5.02%) ⬆️
src/util/dev/server.ts 66.43% <0%> (+5.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c11a57...db6ff31. Read the comment docs.

@TooTallNate
Copy link
Member

Why not just run release (with no arguments) after doing the lerna publishing?

@styfle
Copy link
Member Author

styfle commented Sep 12, 2019

@TooTallNate Because release doesn't work with tags that are not semver. Also it doesn't respect the idea of monorepos which have multiple packages using different versions (I know because I tried it this morning).

@kodiakhq kodiakhq bot merged commit f025f10 into canary Sep 12, 2019
@kodiakhq kodiakhq bot deleted the release-notes branch September 12, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants