Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-static-build] Add hugo, zola, and gutenberg versioning #3025

Merged
merged 6 commits into from Sep 17, 2019
Merged

Conversation

styfle
Copy link
Member

@styfle styfle commented Sep 16, 2019

This PR adds support for build environment variables which enables the user to select which version of Hugo, Zola or Gutenberg they wish to use.

  • HUGO_VERSION
  • ZOLA_VERSION
  • GUTENBERG_VERSION

@codecov-io
Copy link

codecov-io commented Sep 16, 2019

Codecov Report

Merging #3025 into canary will increase coverage by 0.72%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #3025      +/-   ##
==========================================
+ Coverage   11.33%   12.05%   +0.72%     
==========================================
  Files         267      267              
  Lines       10032    10126      +94     
  Branches     1308     1290      -18     
==========================================
+ Hits         1137     1221      +84     
- Misses       8803     8812       +9     
- Partials       92       93       +1
Impacted Files Coverage Δ
src/util/metrics.ts 68.18% <0%> (-2.41%) ⬇️
src/util/projects/get-project-by-id-or-name.ts 28.57% <0%> (+3.57%) ⬆️
src/util/get-files.ts 91.66% <0%> (+3.88%) ⬆️
src/util/prefer-v2-deployment.ts 61.9% <0%> (+5.65%) ⬆️
src/util/output/create-output.ts 43.58% <0%> (+12.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81c2777...9ae0899. Read the comment docs.

@styfle styfle changed the title [now-static-build] Add hugo and zola [now-static-build] Add hugo and zola versioning Sep 16, 2019
@styfle styfle changed the title [now-static-build] Add hugo and zola versioning [now-static-build] Add hugo, zola, and gutenberg versioning Sep 16, 2019
@styfle styfle marked this pull request as ready for review September 16, 2019 20:47
@styfle styfle requested a review from leo September 16, 2019 20:47
@TooTallNate
Copy link
Member

Curious why env vars instead of using the config object of the build spec. Is it because of zero config?

@styfle
Copy link
Member Author

styfle commented Sep 17, 2019

Curious why env vars instead of using the config object of the build spec. Is it because of zero config?

@TooTallNate Yes. Users of static site generators will not define the builds key and therefore, cannot assign build configs. In fact, I don't think we are adding any new config options going forward due to zero config.

@kodiakhq kodiakhq bot merged commit a07082c into canary Sep 17, 2019
@kodiakhq kodiakhq bot deleted the hugo-zola branch September 17, 2019 19:14
styfle added a commit that referenced this pull request Sep 17, 2019
* [now-static-build] Add hugo, zola, and gutenberg versioning

* Add tests

* Export spawnAsync

* Change spawnAsync to remove cwd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants