[builders] Consistently capitalize first letter of logs #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## canary #3039 +/- ##
=========================================
- Coverage 13.46% 13.36% -0.1%
=========================================
Files 267 267
Lines 10296 10275 -21
Branches 1211 1216 +5
=========================================
- Hits 1386 1373 -13
+ Misses 8848 8840 -8
Partials 62 62
Continue to review full report at Codecov.
|
|
Modified files, got auto formatted by pre-commit hook. |
…to builders/capitalize-log-line
thasophearak
requested review from
AndyBitz,
lucleray,
styfle,
Timer and
TooTallNate
as code owners
styfle
reviewed
Sep 19, 2019
| await writeNpmRc(entryPath, process.env.NPM_AUTH_TOKEN); | ||
| } | ||
|
|
||
| debug('installing dependencies...'); | ||
| console.log('Installing dependencies...'); |
There was a problem hiding this comment.
@Sophearak Was this changes to console.log() intentionally?
There was a problem hiding this comment.
It looks like you changed it in every builder so I think that's good 👍
Also I see your PR description says this is intentional 😄
There was a problem hiding this comment.
Indeed, this is intended 🙌
styfle
approved these changes
Sep 19, 2019
styfle
changed the title
styfle
pushed a commit
that referenced
this pull request
Sep 30, 2019
* Consistency capitalize logs line `@now/next` * Consistency capitalize logs line `@now/node` * Consistency capitalize logs line `@now/go` * Consistency capitalize logs line `@now/python` * Always show `Installing dependencies...` * Consistency capitalize logs line `run-user-scripts` * Capitalize `Running`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensure consistency capitalize logs line, as well as make
Installing dependencies...always visible.