Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-static-build] Add test for BUNDLE_WITHOUT env var #3070

Merged
merged 2 commits into from Sep 24, 2019

Conversation

styfle
Copy link
Member

@styfle styfle commented Sep 24, 2019

This adds a test which confirms that BUNDLE_WITHOUT="test:development" works properly.

This env var is equivalent to bundle install --without test development.

There's no code change here because groups are defined by the user, therefore they must define which ones to ignore (if any).

PRODUCT-133 #close

@leo
Copy link
Contributor

leo commented Sep 24, 2019

This is incredible! I'm so glad they already consume the env var on their own.

@kodiakhq kodiakhq bot merged commit 651429c into canary Sep 24, 2019
@kodiakhq kodiakhq bot deleted the bundle-install-without branch September 24, 2019 22:36
styfle added a commit that referenced this pull request Sep 30, 2019
This adds a test which confirms that `BUNDLE_WITHOUT="test:development"` works properly.

This env var is equivalent to `bundle install --without test development`.

There's no code change here because groups are defined by the user, therefore they must define which ones to ignore (if any).

- Groups Guide: https://bundler.io/v2.0/guides/groups.html
- BUNDLER_WITHOUT: https://bundler.io/v2.0/bundle_config.html#LIST-OF-AVAILABLE-KEYS
- Example Gemfile: https://github.com/thoughtbot/administrate/blob/master/Gemfile

PRODUCT-133 #close
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants