Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-next] Invoke build script #3073

Merged
merged 7 commits into from
Sep 27, 2019
Merged

Conversation

thasophearak
Copy link
Contributor

This PR make @now/next invoke build script if user defined.

PRODUCT-106 #close

@codecov-io
Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #3073 into canary will increase coverage by 2.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #3073      +/-   ##
==========================================
+ Coverage   11.33%   13.45%   +2.11%     
==========================================
  Files         268      268              
  Lines       10064    10319     +255     
  Branches     1314     1215      -99     
==========================================
+ Hits         1141     1388     +247     
- Misses       8830     8869      +39     
+ Partials       93       62      -31
Impacted Files Coverage Δ
src/util/metrics.ts 68.18% <0%> (-2.41%) ⬇️
src/util/deploy/process-deployment.ts 0% <0%> (ø) ⬆️
src/util/dev/builder-cache.ts 80.74% <0%> (+3.47%) ⬆️
src/util/projects/get-project-by-id-or-name.ts 28.57% <0%> (+3.57%) ⬆️
src/util/get-files.ts 91.66% <0%> (+3.88%) ⬆️
src/util/dev/router.ts 82.69% <0%> (+4.12%) ⬆️
src/util/dev/builder.ts 76.92% <0%> (+4.4%) ⬆️
src/util/dev/yarn-installer.ts 90.74% <0%> (+5.02%) ⬆️
src/util/dev/server.ts 66.43% <0%> (+5.41%) ⬆️
src/util/prefer-v2-deployment.ts 61.9% <0%> (+5.65%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9a234...b81d5f7. Read the comment docs.

@thasophearak thasophearak marked this pull request as ready for review September 25, 2019 15:49
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a pretty big breaking change as you're preferring build over now-build. It seems like it should prefer now-build and then try and check for build if it doesn't exist.

@timneutkens
Copy link
Member

Great work @Sophearak 🙏

@kodiakhq kodiakhq bot merged commit 6699028 into canary Sep 27, 2019
@kodiakhq kodiakhq bot deleted the now-next/invokie-build-script branch September 27, 2019 02:09
styfle pushed a commit that referenced this pull request Sep 30, 2019
This PR make `@now/next` invoke `build` script if user defined.

PRODUCT-106 #close
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants