-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[now-next] Invoke build script #3073
Conversation
…nto now-next/invokie-build-script
Codecov Report
@@ Coverage Diff @@
## canary #3073 +/- ##
==========================================
+ Coverage 11.33% 13.45% +2.11%
==========================================
Files 268 268
Lines 10064 10319 +255
Branches 1314 1215 -99
==========================================
+ Hits 1141 1388 +247
- Misses 8830 8869 +39
+ Partials 93 62 -31
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a pretty big breaking change as you're preferring build
over now-build
. It seems like it should prefer now-build
and then try and check for build
if it doesn't exist.
Great work @Sophearak 🙏 |
This PR make `@now/next` invoke `build` script if user defined. PRODUCT-106 #close
This PR make
@now/next
invokebuild
script if user defined.PRODUCT-106 #close