[now-build-utils] Allow prerender groups to be defined with an integer #3081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyBitz
approved these changes
Sep 26, 2019
|
Just for clarification purposes, the intended return document from a builder would look along these lines, correct? {
"output": {
"releases": {
"type": "prerender",
"expiration": 1,
"lambda": "[Lambda]",
"fallback": "[FileBlob | FileFsRef | FileRef]",
"group": 1
},
"_next/data/releases.json": {
"type": "prerender",
"expiration": 1,
"lambda": "[Lambda]",
"fallback": "[FileBlob | FileFsRef | FileRef]",
"group": 1
},
"community": {
"type": "prerender",
"expiration": 1,
"lambda": "[Lambda]",
"fallback": "[FileBlob | FileFsRef | FileRef]",
"group": 2
},
"_next/data/community.json": {
"type": "prerender",
"expiration": 1,
"lambda": "[Lambda]",
"fallback": "[FileBlob | FileFsRef | FileRef]",
"group": 2
}
}
} |
styfle
changed the title
|
Correct @Timer 👍 |
Timer
approved these changes
Sep 26, 2019
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 26, 2019
As of #3081, we make it necessary to group `Prerenders` together for being invalidated at the same time. However, you might not want that. In turn, we'll make it optional.
styfle
pushed a commit
that referenced
this pull request
Sep 30, 2019
#3081) This pull request removes the `PrerenderGroup` type in favor of a `group` parameter for the existing `Prerender` type. This parameter takes in an integer that defines a group of prerenders that should be invalidated at the same time: ``` interface Prerender { expiration: number; lambda: Lambda; fallback: FileBlob | FileFsRef | FileRef; group: number; } ``` **Example:** If two `Prerender` instances exist that have `group` set to `1`, they will both be invalidated at the same time.
styfle
pushed a commit
that referenced
this pull request
Sep 30, 2019
As of #3081, we make it necessary to group `Prerenders` together for being invalidated at the same time. However, you might not want that. In turn, we'll make it optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the
PrerenderGrouptype in favor of agroupparameter for the existingPrerendertype.This parameter takes in an integer that defines a group of prerenders that should be invalidated at the same time:
Example: If two
Prerenderinstances exist that havegroupset to1, they will both be invalidated at the same time.