Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-static-build] Make curl silent #3090

Merged
merged 1 commit into from Sep 27, 2019
Merged

[now-static-build] Make curl silent #3090

merged 1 commit into from Sep 27, 2019

Conversation

styfle
Copy link
Member

@styfle styfle commented Sep 27, 2019

We added a message in #3068 so this PR makes curl silent unless it errors.

Also fix typo in Gutenberg 😉

PRODUCT-7 #close

@kodiakhq kodiakhq bot merged commit 7911d58 into canary Sep 27, 2019
@codecov-io
Copy link

Codecov Report

Merging #3090 into canary will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #3090      +/-   ##
==========================================
+ Coverage   11.33%   11.34%   +<.01%     
==========================================
  Files         268      268              
  Lines       10064    10068       +4     
  Branches     1314     1313       -1     
==========================================
+ Hits         1141     1142       +1     
- Misses       8830     8833       +3     
  Partials       93       93
Impacted Files Coverage Δ
src/commands/deploy/latest.js 0% <0%> (ø) ⬆️
src/util/handle-error.ts 38.88% <0%> (ø) ⬆️
src/commands/deploy/legacy.ts 0% <0%> (ø) ⬆️
src/util/deploy/process-deployment.ts 0% <0%> (ø) ⬆️
src/util/deploy/create-deploy.js 0% <0%> (ø) ⬆️
src/util/errors-ts.ts 47.48% <0%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05a44a0...717d856. Read the comment docs.

@kodiakhq kodiakhq bot deleted the silent-curl branch September 27, 2019 14:16
styfle added a commit that referenced this pull request Sep 30, 2019
We added a message in #3068 so this PR makes curl silent unless it errors.

Also fix typo in Gutenberg 😉 

PRODUCT-7 #close
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants