Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-static-build] Print version of static generator during build #3068

Merged
merged 3 commits into from Sep 24, 2019

Conversation

styfle
Copy link
Member

@styfle styfle commented Sep 24, 2019

If an environment variable such as HUGO_VERSION is used, we want to always render the version that we used in the logs.

If no such env var is used, we don’t want to log anything.

PRODUCT-132 #close

@kodiakhq kodiakhq bot merged commit 947f909 into canary Sep 24, 2019
@kodiakhq kodiakhq bot deleted the print-version branch September 24, 2019 21:14
@codecov-io
Copy link

Codecov Report

Merging #3068 into canary will increase coverage by 1.86%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #3068      +/-   ##
==========================================
+ Coverage    11.6%   13.47%   +1.86%     
==========================================
  Files         267      267              
  Lines       10069    10301     +232     
  Branches     1299     1212      -87     
==========================================
+ Hits         1169     1388     +219     
- Misses       8809     8851      +42     
+ Partials       91       62      -29
Impacted Files Coverage Δ
src/util/metrics.ts 68.18% <0%> (-2.41%) ⬇️
src/util/projects/get-project-by-id-or-name.ts 28.57% <0%> (+3.57%) ⬆️
src/util/get-files.ts 91.66% <0%> (+3.88%) ⬆️
src/util/dev/router.ts 82.69% <0%> (+4.12%) ⬆️
src/util/dev/builder.ts 76.92% <0%> (+4.4%) ⬆️
src/util/dev/yarn-installer.ts 90.74% <0%> (+5.02%) ⬆️
src/util/dev/server.ts 66.43% <0%> (+5.41%) ⬆️
src/util/prefer-v2-deployment.ts 61.9% <0%> (+5.65%) ⬆️
src/util/output/create-output.ts 43.58% <0%> (+12.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f16b6...5c525e4. Read the comment docs.

kodiakhq bot pushed a commit that referenced this pull request Sep 27, 2019
We added a message in #3068 so this PR makes curl silent unless it errors.

Also fix typo in Gutenberg 😉 

PRODUCT-7 #close
styfle added a commit that referenced this pull request Sep 30, 2019
)

* [now-static-build] Print version of static generator

* Use curl progress bar
styfle added a commit that referenced this pull request Sep 30, 2019
We added a message in #3068 so this PR makes curl silent unless it errors.

Also fix typo in Gutenberg 😉 

PRODUCT-7 #close
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants