[now-cli] Spawn builder child processes with stdio: 'inherit' in now dev
#3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow dev` Inherit the `now dev` process stdio streams in builder child processes, so that ANSI color codes may be used when stdout is a TTY.
AndyBitz
approved these changes
Oct 2, 2019
styfle
reviewed
Oct 3, 2019
styfle
reviewed
Oct 3, 2019
|
Need to look into why this is causing the unit tests to hang. Surely has to do with builder child processes not exiting correctly / completely. |
styfle
approved these changes
Oct 3, 2019
TooTallNate
added a commit
that referenced
this pull request
Oct 8, 2019
Explicitly send the SIGINT / SIGTERM signal to `now dev` server child processes, so that they are not left running when running the now-dev unit tests. Related to #3113 which has hanging unit tests that never "complete".
TooTallNate
added a commit
that referenced
this pull request
Oct 8, 2019
Explicitly send the SIGINT / SIGTERM signal to `now dev` server child processes, so that they are not left running when running the now-dev unit tests. Related to #3113 which has hanging unit tests that never "complete".
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 8, 2019
Explicitly send the SIGINT / SIGTERM signal to `now dev` server child processes, so that they are not left running when running the now-dev unit tests. Related to #3113 which has hanging unit tests that never "complete".
Codecov Report
@@ Coverage Diff @@
## canary #3113 +/- ##
==========================================
+ Coverage 12.29% 12.32% +0.02%
==========================================
Files 268 268
Lines 10204 10196 -8
Branches 1279 1275 -4
==========================================
+ Hits 1255 1257 +2
+ Misses 8859 8852 -7
+ Partials 90 87 -3
Continue to review full report at Codecov.
|
styfle
reviewed
Oct 16, 2019
packages/now-cli/test/fixtures/unit/now-dev-static-build-routing/now.json
Show resolved
Hide resolved
styfle
approved these changes
Oct 16, 2019
AndyBitz
approved these changes
Oct 16, 2019
Timer
pushed a commit
that referenced
this pull request
Oct 20, 2019
Explicitly send the SIGINT / SIGTERM signal to `now dev` server child processes, so that they are not left running when running the now-dev unit tests. Related to #3113 which has hanging unit tests that never "complete".
TooTallNate
added a commit
that referenced
this pull request
Oct 21, 2019
…ow dev` (#3113) Inherit the `now dev` process stdio streams in builder child processes, so that ANSI color codes may be used when stdout is a TTY. **Examples:** _Next.js_ <img width="523" alt="Screen Shot 2019-10-01 at 3 42 33 PM" src="https://user-images.githubusercontent.com/71256/66006087-4fe75780-e462-11e9-927f-1e81466c4108.png"> _Gatsby_ (depends on #3112) <img width="507" alt="Screen Shot 2019-10-01 at 3 40 02 PM" src="https://user-images.githubusercontent.com/71256/66006094-5d9cdd00-e462-11e9-81da-e60bd9516778.png"> Fixes #3135.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inherit the
now devprocess stdio streams in builder child processes, so that ANSI color codes may be used when stdout is a TTY.Examples:
Next.js
Gatsby (depends on #3112)
Fixes #3135.