[now-cli] Disable --prod and --target for Now 1.0 deployments
#3189
Conversation
| if (argv.prod) { | ||
| error( | ||
| `Now 1.0 does not support Production Deployments. Please use Now 2.0 to take advantage this feature: ${link( | ||
| 'https://zeit.co/upgrade' |
There was a problem hiding this comment.
Should we also tell the user how to achieve what they want for the 1.0 deployment? (i.e. manual now alias or whatever?)
There was a problem hiding this comment.
Option --prod is not supported for Now 1.0 deployments. To manually alias a deployment, use now alias instead.
(and I drop the "update" message)
What do you think @leo @TooTallNate ?
There was a problem hiding this comment.
That's great! But let's make now alias use a code snippet.
lucleray
changed the title
now --prod for Now 1.0 deployments--prod and --target for Now 1.0 deployments
Codecov Report
@@ Coverage Diff @@
## canary #3189 +/- ##
=========================================
+ Coverage 13.33% 13.54% +0.2%
=========================================
Files 268 268
Lines 10312 10339 +27
Branches 1211 1214 +3
=========================================
+ Hits 1375 1400 +25
Misses 8877 8877
- Partials 60 62 +2
Continue to review full report at Codecov.
|
) This PR disables Now 1.0 production deployments with the following error message: > Option --prod is not supported for Now 1.0 deployments. To manually alias a deployment, use `now alias` instead. It looks like this: <img width="835" alt="Capture d’écran 2019-10-23 à 19 42 09" src="https://user-images.githubusercontent.com/6616955/67419574-3e125380-f5cd-11e9-81ff-63bde292539b.png"> Also disables `--target` for Now 1.0 deployments.
This PR disables Now 1.0 production deployments with the following error message:
It looks like this:
Also disables
--targetfor Now 1.0 deployments.