[now-cli][now-client] Add support for functions property
#3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdev
reviewed
Oct 31, 2019
rdev
approved these changes
Oct 31, 2019
styfle
reviewed
Oct 31, 2019
styfle
reviewed
Oct 31, 2019
styfle
approved these changes
Oct 31, 2019
leo
pushed a commit
that referenced
this pull request
Nov 11, 2019
* [now-cli][now-client] Add support for `functions` property * Fix typo * Update yarn.lock for test * Update all yarn.lock files for now dev * Log fixture that failed * Use catch instead * Run dev tests not serial * Revert "Run dev tests not serial" This reverts commit bfcd836. * Do not throw * Skip nextjs tests on node 8 * Remove only flag * Ignore 19-mithril * Revert "Ignore 19-mithril" This reverts commit d438c40. * Revert "Remove only flag" This reverts commit caff05a. * Revert "Skip nextjs tests on node 8" This reverts commit 3b45ca3. * Revert "Do not throw" This reverts commit 55624b9. * Revert "Revert "Run dev tests not serial"" This reverts commit cd5260a. * Revert "Run dev tests not serial" This reverts commit bfcd836. * Revert "Use catch instead" This reverts commit fe65299. * Revert "Log fixture that failed" This reverts commit feb0e7b. * Revert "Update all yarn.lock files for now dev" This reverts commit 36be4dd. * Update yarn.lock for 14-svelte-node * Update es-abstract in all yarn.lock files * Skip node test * Revert "Skip node test" This reverts commit c9c45ec. * Remove test.only * Only execute node test in now-dev * Revert "Only execute node test in now-dev" This reverts commit 8ab7a88. * Clean cache on macos node8 * Fix query * Use --skip-integrity-check * Add --skip-integrity-check to different yarn call * Add --network-concurrency 1 * Add retry
comus
added a commit
to withcloud/now
that referenced
this pull request
Nov 23, 2019
* commit 'ba18a3a0cbada71104184d2fdb9b3d9bde48a193': (161 commits) [now-cli] Add note for Windows environment variable syntax (vercel#3243) [docs] Rename "Builders" to "Runtimes" (vercel#3256) Update Public Directory Link (vercel#3221) Publish [now-next] 404 Known Static Files Before Dynamic Routes (vercel#3238) Publish [now-cli] Adjust `now ls` according to new project overview (vercel#3229) [now dev] Add support for `cleanUrls` (vercel#3240) [now-cli] Fix test invalid-builder-routes (vercel#3249) [now-cli] Remove `now upgrade` command (vercel#3228) [now-dev] Fix route normalization (vercel#3225) Publish [now-build-utils] Fix custom function runtimes (vercel#3239) Publish [now-cli][now-client] Add support for `functions` property (vercel#3231) Publish Fix racing spinners (vercel#3232) Publish [now-routing-utils] Fix newline in error message (vercel#3234) [now-build-utils] Fix zero config trailing slash (vercel#3233) ... # Conflicts: # packages/now-node/package.json # packages/now-node/src/index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
functions.It makes sure it will be part of the payload and adds a bunch of tests for it to verify it works.