Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-routing-utils] Fix newline in error message #3234

Merged
merged 2 commits into from
Oct 31, 2019

Conversation

styfle
Copy link
Member

@styfle styfle commented Oct 31, 2019

The newlines were not being applied properly since the entry array was stringified.

This PR fixes the newlines for route errors.

@kodiakhq kodiakhq bot merged commit 4d7aaff into canary Oct 31, 2019
@kodiakhq kodiakhq bot deleted the PRODUCT-341/routing-error-newline branch October 31, 2019 16:49
leo pushed a commit that referenced this pull request Nov 11, 2019
The newlines were not being applied properly since the entry array was stringified.

This PR fixes the newlines for route errors.
comus added a commit to withcloud/now that referenced this pull request Nov 23, 2019
* commit 'ba18a3a0cbada71104184d2fdb9b3d9bde48a193': (161 commits)
  [now-cli] Add note for Windows environment variable syntax (vercel#3243)
  [docs] Rename "Builders" to "Runtimes" (vercel#3256)
  Update Public Directory Link (vercel#3221)
  Publish
  [now-next] 404 Known Static Files Before Dynamic Routes (vercel#3238)
  Publish
  [now-cli] Adjust `now ls` according to new project overview (vercel#3229)
  [now dev] Add support for `cleanUrls` (vercel#3240)
  [now-cli] Fix test invalid-builder-routes (vercel#3249)
  [now-cli] Remove `now upgrade` command (vercel#3228)
  [now-dev] Fix route normalization (vercel#3225)
  Publish
  [now-build-utils] Fix custom function runtimes (vercel#3239)
  Publish
  [now-cli][now-client] Add support for `functions` property (vercel#3231)
  Publish
  Fix racing spinners (vercel#3232)
  Publish
  [now-routing-utils] Fix newline in error message (vercel#3234)
  [now-build-utils] Fix zero config trailing slash (vercel#3233)
  ...

# Conflicts:
#	packages/now-node/package.json
#	packages/now-node/src/index.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants