Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@now/node] Configure helpers and handler with env variables #3286

Merged
merged 22 commits into from
Nov 11, 2019

Conversation

AndyBitz
Copy link
Contributor

@AndyBitz AndyBitz commented Nov 11, 2019

Allow to configure helpers and handler with env variables.

PRODUCT-27

packages/now-node/src/index.ts Outdated Show resolved Hide resolved
packages/now-node/src/index.ts Outdated Show resolved Hide resolved
Co-Authored-By: Luc <luc.leray@gmail.com>
Copy link
Member

@lucleray lucleray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add tests for that behaviour?

@leo leo requested a review from lucleray November 11, 2019 13:48
@AndyBitz AndyBitz requested review from lucleray and removed request for lucleray November 11, 2019 13:56
@leo leo changed the base branch from canary to master November 11, 2019 13:59
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@leo leo added the automerge label Nov 11, 2019
@kodiakhq kodiakhq bot merged commit f8f9d65 into master Nov 11, 2019
@AndyBitz AndyBitz deleted the now-node/env-configuration branch November 11, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants