Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust commands for creating releases #3287

Merged
merged 7 commits into from
Nov 11, 2019
Merged

Adjust commands for creating releases #3287

merged 7 commits into from
Nov 11, 2019

Conversation

leo
Copy link
Contributor

@leo leo commented Nov 11, 2019

Now that we're using a single branch, we need to adjust the release commands accordingly.

@leo leo added the automerge label Nov 11, 2019
@leo leo requested review from AndyBitz and styfle November 11, 2019 14:30
styfle
styfle approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@styfle styfle left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We'll also need to update the diff.js and changelog.js scripts. We probably won't need diff.js but we will want a changelog.js script for generating release notes.

styfle
styfle reviewed Nov 11, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
styfle
styfle reviewed Nov 11, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
leo and others added 2 commits November 11, 2019 15:37
@leo @styfle
Update package.json
149d856 
Co-Authored-By: Steven <steven@ceriously.com>
@leo @styfle
Update package.json
20b25d6 
Co-Authored-By: Steven <steven@ceriously.com>
@leo
Copy link
Contributor Author

leo commented Nov 11, 2019

@styfle Great call! I also adjusted the docs.

styfle
styfle approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌

@styfle
Copy link
Member

styfle commented Nov 11, 2019 •
edited

@leo You also need to update line 23 of run.js to be:

const gitPath = branch === 'master' ? 'HEAD~1' : 'origin/master...HEAD';

@styfle styfle merged commit c9572c3 into master Nov 11, 2019
@styfle styfle deleted the single-branch branch November 11, 2019 15:50
@styfle styfle mentioned this pull request Nov 11, 2019
Merged
kodiakhq bot pushed a commit that referenced this pull request Nov 11, 2019
@styfle @kodiakhq
[docs] Cleanup canary links, use master instead (#3291)
b357f30 
Follow up to #3287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@TooTallNate TooTallNate Awaiting requested review from TooTallNate

@AndyBitz AndyBitz Awaiting requested review from AndyBitz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leo @styfle