[tests] Always test now-cli #3305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TooTallNate
reviewed
Nov 12, 2019
TooTallNate
approved these changes
Nov 12, 2019
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 12, 2019
This PR reduces the time running Circle CI tests. Since creating the monorepo in #2812, the coverage broke and then was fixed in #2876 with a workaround which would run unit tests twice. More recently, we enabled Now CLI to always run tests in #3305 so that means coverage data is always generated. This PR is a final proper fix so that unit tests run once which saves approximately 2 minutes per push (CI workflow).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only the changed package's tests would run.
This PR makes sure that the changed package +
now-clitests run every time.