Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-build-utils][now-static-build][now-node] Add node 12.x #3330

Merged
merged 11 commits into from
Nov 20, 2019

Conversation

styfle
Copy link
Member

@styfle styfle commented Nov 19, 2019

This PR adds support for Node 12 when the user defines engines in their package.json

@styfle styfle requested a review from leo as a code owner November 19, 2019 19:51
@styfle styfle changed the title [now-build-utils][now-node] Add node 12 support [now-build-utils][now-static-build][now-node] Add node 12 support Nov 19, 2019
@styfle styfle changed the title [now-build-utils][now-static-build][now-node] Add node 12 support [now-build-utils][now-static-build][now-node] Add node 12.x Nov 19, 2019
@kodiakhq kodiakhq bot merged commit a229747 into master Nov 20, 2019
@kodiakhq kodiakhq bot deleted the PRODUCT-677/now-node-12 branch November 20, 2019 02:34
@codecov-io
Copy link

Codecov Report

Merging #3330 into master will increase coverage by 2.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3330      +/-   ##
==========================================
+ Coverage   11.67%   13.76%   +2.08%     
==========================================
  Files         267      267              
  Lines       10182    10446     +264     
  Branches     1357     1262      -95     
==========================================
+ Hits         1189     1438     +249     
- Misses       8896     8937      +41     
+ Partials       97       71      -26
Impacted Files Coverage Δ
src/util/metrics.ts 68.18% <0%> (-2.41%) ⬇️
src/util/dev/builder-cache.ts 84.66% <0%> (+2.64%) ⬆️
src/util/dev/router.ts 80.76% <0%> (+3.49%) ⬆️
src/util/get-files.ts 91.08% <0%> (+4.26%) ⬆️
src/util/projects/get-project-by-id-or-name.ts 26.66% <0%> (+4.44%) ⬆️
src/util/dev/builder.ts 70.49% <0%> (+5.1%) ⬆️
src/util/dev/yarn-installer.ts 89.09% <0%> (+5.36%) ⬆️
src/util/dev/server.ts 64.61% <0%> (+5.77%) ⬆️
src/util/prefer-v2-deployment.ts 60.46% <0%> (+5.91%) ⬆️
src/util/output/create-output.ts 65% <0%> (+7.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b59c3...af4554d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants