-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[now-build-utils][now-static-build][now-node] Add node 12.x #3330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
requested review from
AndyBitz,
lucleray and
TooTallNate
as code owners
November 19, 2019 18:39
TooTallNate
approved these changes
Nov 19, 2019
styfle
changed the title
[now-build-utils][now-node] Add node 12 support
[now-build-utils][now-static-build][now-node] Add node 12 support
Nov 19, 2019
styfle
changed the title
[now-build-utils][now-static-build][now-node] Add node 12 support
[now-build-utils][now-static-build][now-node] Add node 12.x
Nov 19, 2019
Codecov Report
@@ Coverage Diff @@
## master #3330 +/- ##
==========================================
+ Coverage 11.67% 13.76% +2.08%
==========================================
Files 267 267
Lines 10182 10446 +264
Branches 1357 1262 -95
==========================================
+ Hits 1189 1438 +249
- Misses 8896 8937 +41
+ Partials 97 71 -26
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Node 12 when the user defines
engines
in theirpackage.json