Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-ruby] Add rack examples to ruby integration tests #3626

Merged
merged 6 commits into from Jan 27, 2020
Merged

[now-ruby] Add rack examples to ruby integration tests #3626

merged 6 commits into from Jan 27, 2020

Conversation

m5o
Copy link
Contributor

@m5o m5o commented Jan 20, 2020

* add rack examples to ruby integration tests
  * https://github.com/rack/rack
@vercel
Copy link

vercel bot commented Jan 20, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/zeit/now/egyflffvd
✅ Preview: https://now-git-fork-m5o-ruby-test-rack.zeit.now.sh

@codecov-io
Copy link

Codecov Report

Merging #3626 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3626      +/-   ##
==========================================
- Coverage   14.06%   14.06%   -0.01%     
==========================================
  Files         275      275              
  Lines       11166    11178      +12     
  Branches     1539     1540       +1     
==========================================
+ Hits         1571     1572       +1     
- Misses       9426     9437      +11     
  Partials      169      169
Impacted Files Coverage Δ
src/util/metrics.ts 61.53% <0%> (-6.65%) ⬇️
src/util/prefer-v2-deployment.ts 55.1% <0%> (-4.9%) ⬇️
src/util/projects/get-project-by-id-or-name.ts 19.04% <0%> (-4.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20fdcfa...328a7cf. Read the comment docs.

@styfle styfle changed the title add rack examples to ruby integration tests [now-ruby] Add rack examples to ruby integration tests Jan 22, 2020
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙌

@styfle styfle merged commit 882bc8c into vercel:master Jan 27, 2020
@m5o m5o deleted the ruby-test-rack branch January 27, 2020 21:59
kodiakhq bot pushed a commit that referenced this pull request Feb 28, 2020
* update bundler on ruby rack examples
  * bundle with latest bundler `v2.1.4`
  * update rack to `v2.2.2`
  🔗 #3626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants