Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[now-build-utils] Add function detectApiExtensions() #3653

Merged
merged 7 commits into from Jan 24, 2020

Conversation

styfle
Copy link
Member

@styfle styfle commented Jan 23, 2020

We are adding routes with redirects, only if we detect extensions.

This PR makes sure that file renaming uses the same pattern.

@vercel
Copy link

vercel bot commented Jan 23, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/zeit/now/fwg5htt94
✅ Preview: https://now-git-product-341-add-detect-api-exts.zeit.now.sh

@styfle styfle changed the title [now-routing-utils] Add function detectApiExtensions [now-routing-utils] Add function detectApiExtensions() Jan 23, 2020
@styfle styfle changed the title [now-routing-utils] Add function detectApiExtensions() [now-build-utils] Add function detectApiExtensions() Jan 23, 2020
@styfle styfle marked this pull request as ready for review January 23, 2020 23:16
@styfle styfle requested a review from dav-is January 23, 2020 23:16
runtime: 'now-rust@1.0.1',
},
},
},
Copy link
Member Author

@styfle styfle Jan 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndyBitz I deployed a rust project and found that the src is actually not the glob from functions but every file gets its own build. So I made sure this test uses the same input.

@styfle styfle merged commit 243451e into master Jan 24, 2020
@styfle styfle deleted the PRODUCT-341/add-detect-api-exts branch January 24, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants