Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Invalidate build match for changes to config in builds #4603

Merged
merged 7 commits into from Jun 9, 2020

Conversation

TooTallNate
Copy link
Member

@TooTallNate TooTallNate commented Jun 9, 2020

  • Fixes changing a config value in the builds array (such as helpers: false for @vercel/node) and having it be reflected in vc dev without restarting the dev server.
  • Re-validates the env vars configuration when a .env file changes or the env object is changed in vercel.json (same for the builds equivalents).
  • Ensures that the NODEJS_HELPERS build env var is being properly checked in startDevServer().
  • Regenerated the yarn.lock file because yarn was erroring when trying to add the fast-deep-equal dependency.

This fixes changing a `config` value in the `builds` array (such as
`helpers: false` for `@vercel/node`) and having it be reflected in
`vc dev` without restarting the dev server.

Also regenerated the `yarn.lock` file because yarn was erroring when
trying to add the `fast-deep-equal` dependency.
@kodiakhq kodiakhq bot merged commit 88cd9ca into master Jun 9, 2020
@kodiakhq kodiakhq bot deleted the update/vc-dev-modified-builds-config branch June 9, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants