New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] Invalidate build match for changes to config
in builds
#4603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes changing a `config` value in the `builds` array (such as `helpers: false` for `@vercel/node`) and having it be reflected in `vc dev` without restarting the dev server. Also regenerated the `yarn.lock` file because yarn was erroring when trying to add the `fast-deep-equal` dependency.
TooTallNate
commented
Jun 9, 2020
styfle
reviewed
Jun 9, 2020
styfle
reviewed
Jun 9, 2020
styfle
approved these changes
Jun 9, 2020
AndyBitz
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config
value in thebuilds
array (such ashelpers: false
for@vercel/node
) and having it be reflected invc dev
without restarting the dev server..env
file changes or theenv
object is changed invercel.json
(same for the builds equivalents).NODEJS_HELPERS
build env var is being properly checked instartDevServer()
.yarn.lock
file because yarn was erroring when trying to add thefast-deep-equal
dependency.