Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[redwoood] Add runtime @vercel/redwood #4676

Merged
merged 23 commits into from
Jul 23, 2020
Merged

[redwoood] Add runtime @vercel/redwood #4676

merged 23 commits into from
Jul 23, 2020

Conversation

styfle
Copy link
Member

@styfle styfle commented Jun 17, 2020 •
edited

Changes

  • Add new Runtime: @vercel/redwood
  • Update run.js script to sort packages properly

Related

@styfle styfle marked this pull request as ready for review June 18, 2020 00:21
@styfle styfle requested a review from TooTallNate as a code owner June 18, 2020 00:21
@styfle styfle changed the title Add redwood Add @vercel/redwood Jun 18, 2020
@styfle styfle requested a review from AndyBitz June 18, 2020 15:15
AndyBitz
AndyBitz previously approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@AndyBitz AndyBitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great 👍

Just noticed a few console.log calls, not sure if you want to keep those @styfle

packages/redwood/src/index.ts Outdated Show resolved Hide resolved
packages/redwood/src/index.ts Outdated Show resolved Hide resolved
packages/redwood/src/index.ts Outdated Show resolved Hide resolved
@vercel vercel bot requested a deployment to Preview July 13, 2020 15:31 Abandoned
@vercel vercel bot requested a deployment to Preview July 13, 2020 15:35 Abandoned
@styfle styfle removed the automerge label Jul 22, 2020
@styfle styfle requested a review from AndyBitz July 22, 2020 20:58
AndyBitz
AndyBitz previously approved these changes Jul 22, 2020
View reviewed changes
TooTallNate
TooTallNate reviewed Jul 22, 2020
View reviewed changes
packages/redwood/build.sh Show resolved Hide resolved
packages/redwood/package.json Outdated Show resolved Hide resolved
packages/redwood/src/index.ts Outdated Show resolved Hide resolved
utils/run.js Show resolved Hide resolved
@styfle styfle merged commit b118e46 into master Jul 23, 2020
@styfle styfle deleted the feature/styfle/ch1718 branch July 23, 2020 20:22
@styfle styfle mentioned this pull request Jul 23, 2020
Merged
styfle added a commit that referenced this pull request Jul 23, 2020
@styfle @lachlanjc
[frameworks] Add autodetection for RedwoodJS (#4915)
19d0db7 
- Supersedes #4539
- Related to #4676

Co-authored-by: Lachlan Campbell <lachlan@hackclub.com>
@kwnstantina kwnstantina mentioned this pull request Nov 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TooTallNate TooTallNate TooTallNate approved these changes

@AndyBitz AndyBitz AndyBitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@styfle @TooTallNate @AndyBitz