[frameworks] Add autodetection for RedwoodJS #4915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Steven <steven@ceriously.com>
styfle
requested review from
AndyBitz,
mcsdevv,
timothyis and
TooTallNate
as code owners
styfle
added
@vercel/static-build
area: build-utils
and removed
@vercel/static-build
labels
AndyBitz
reviewed
Jul 23, 2020
| "value": "yarn rw db up --no-db-client --auto-approve && yarn rw build" | ||
| }, | ||
| "devCommand": { | ||
| "value": "yarn rw dev" |
There was a problem hiding this comment.
Don't we need to add --port $PORT or something to pass the port?
There was a problem hiding this comment.
They don't support that flag unfortunately, they use a redwood.toml file to set the port.
There was a problem hiding this comment.
My understanding is that this dev command won't be used, since the @vercel/redwood Runtime is special-cased. Is that correct?
There was a problem hiding this comment.
It uses config.devCommand here:
vercel/packages/redwood/src/index.ts
Line 92 in 041e8cc
So it could be overridden if the user changes their project settings.
TooTallNate
approved these changes
Jul 23, 2020
AndyBitz
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vercel/redwood#4676