[cli] Use the configured "Output Directory" from project's settings in vc dev
#4715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n `vc dev` Previously, when a project has a specific "Output Directory" configured in the project settings page, it was not being correctly considered when using `vercel dev`. The main fix here is passing in the full project settings object (including the `outputDirectory`) to the `detectBuilders()` function. Also cleaned up a few types and updated the error message that was previously being rendered to use a short link.
TooTallNate
added
automerge
triaged: bug
AndyBitz
approved these changes
Jun 26, 2020
styfle
reviewed
Jun 26, 2020
styfle
reviewed
Jun 26, 2020
styfle
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a project has a specific "Output Directory" configured in the project settings page, it was not being correctly considered when using
vercel dev.The main fix here is passing in the full project settings object (including the
outputDirectory) to thedetectBuilders()function.Also cleaned up a few types and updated the error message that was previously being rendered to use a short link.