Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Handle API Error action property #4825

Merged
merged 3 commits into from
Jul 9, 2020
Merged

[cli] Handle API Error action property #4825

merged 3 commits into from
Jul 9, 2020

Conversation

lucleray
Copy link
Member

@lucleray lucleray commented Jul 9, 2020 •
edited

  • Use "Learn More" by default
  • Replace with error.action if present

Looks like this:
image

@lucleray lucleray requested a review from nkzawa July 9, 2020 15:24
nkzawa
nkzawa previously approved these changes Jul 9, 2020
View reviewed changes
@lucleray lucleray merged commit ac1f4cf into master Jul 9, 2020
@lucleray lucleray deleted the handle-error-action branch July 9, 2020 20:14
styfle
styfle reviewed Jul 9, 2020
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucleray Oh this is missing one:

vercel/packages/now-cli/src/util/output/create-output.ts

Line 70 in ac1f4cf

action = 'More details'

@lucleray lucleray mentioned this pull request Jul 9, 2020
Merged
styfle pushed a commit that referenced this pull request Jul 9, 2020
@lucleray
replace "more details" with "learn more" (#4828)
ed4d006 
Follow up to PR #4825. Replace more "More details" with "Learn More".
@snyk-bot snyk-bot mentioned this pull request Dec 23, 2021
Open
@zachlewis2020 zachlewis2020 mentioned this pull request May 14, 2022
Open
This was referenced Oct 5, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@TooTallNate TooTallNate TooTallNate approved these changes

@nkzawa nkzawa nkzawa left review comments

Assignees
No one assigned
Labels
area: cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lucleray @TooTallNate @styfle @nkzawa