[cli] Replace "More details" with "Learn More" #4828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyBitz
approved these changes
Jul 9, 2020
styfle
reviewed
Jul 9, 2020
| @@ -496,7 +496,7 @@ function getMissingBuildScriptError() { | |||
| code: 'missing_build_script', | |||
| message: | |||
| 'Your `package.json` file is missing a `build` property inside the `scripts` property.' + | |||
| '\nMore details: https://vercel.com/docs/v2/platform/frequently-asked-questions#missing-build-script', | |||
| '\nLearn More: https://vercel.com/docs/v2/platform/frequently-asked-questions#missing-build-script', | |||
There was a problem hiding this comment.
Can you use link and action here?
There was a problem hiding this comment.
I'm not sure 🤔 I'm trying to improve it a little step at a time, so I haven't looked at whether we properly handle the error object in all the cases here.
styfle
approved these changes
Jul 9, 2020
TooTallNate
changed the title
TooTallNate
approved these changes
Jul 9, 2020
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #4825. Replace more "More details" with "Learn More".