Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] Don't trace pages for lambdas when not needed #4841

Merged
merged 7 commits into from
Jul 22, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jul 12, 2020

When pages are fully static and don't leverage preview mode or revalidation we can skip tracing the pages for generating the lambdas since lambdas aren't needed in this case

@ijjk ijjk requested a review from Timer as a code owner July 12, 2020 05:21
timneutkens
timneutkens previously approved these changes Jul 12, 2020
Timer
Timer previously approved these changes Jul 22, 2020
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests are passing.

Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed code for canary upgrade

@kodiakhq kodiakhq bot merged commit ab7fd52 into master Jul 22, 2020
@kodiakhq kodiakhq bot deleted the ijjk/next/remove-extra-tracing branch July 22, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants