[build-utils] Fix redwood /api detection
#4916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyBitz
approved these changes
Jul 23, 2020
| if (frontendBuilder && framework === 'redwoodjs') { | ||
| // RedwoodJS uses the /api directory differently so we must | ||
| // clear any existing builders and only use `@vercel/redwood`. | ||
| builders.length = 0; |
There was a problem hiding this comment.
Its a bit of a hack but it avoids changing const builders to let builders 😅
TooTallNate
approved these changes
Jul 23, 2020
| // RedwoodJS uses the /api directory differently so we must | ||
| // clear any existing builders and only use `@vercel/redwood`. | ||
| builders.length = 0; | ||
| builders.push(frontendBuilder); |
There was a problem hiding this comment.
Do we need to print a warning here?
There was a problem hiding this comment.
This is not really a warning, this is the expected behavior. I updated the PR description with more info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the zero detection would see js files in the
/apidirectory and attempt to use@vercel/node. However, this doesn't work with RedwoodJS which uses a different format for/apiso we must only use@vercel/redwoodwhen RedwoodJS is detected.