Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] Fix lambda opt-out for index page #4950

Merged
merged 3 commits into from
Jul 29, 2020
Merged

[next] Fix lambda opt-out for index page #4950

merged 3 commits into from
Jul 29, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jul 29, 2020

This makes sure we detect a fully static /index page correctly since the prerender-manifest lists it as / and we were expecting /index during the lambda building opt-out check

x-ref: vercel/next.js#15619

@ijjk ijjk requested a review from Timer as a code owner July 29, 2020 14:50
@ijjk ijjk requested a review from timneutkens July 29, 2020 14:50
timneutkens
timneutkens previously approved these changes Jul 29, 2020
View reviewed changes
Timer
Timer previously approved these changes Jul 29, 2020
View reviewed changes
@ijjk ijjk added the automerge label Jul 29, 2020
@ijjk ijjk dismissed stale reviews from Timer and timneutkens via c8f8faf July 29, 2020 16:57
@ijjk ijjk requested review from Timer and timneutkens July 29, 2020 16:57
@styfle styfle merged commit 99cab6f into master Jul 29, 2020
@styfle styfle deleted the ijjk/next/correct-lambda-opt-out branch July 29, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timer Timer Timer approved these changes

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ijjk @Timer @timneutkens @styfle