Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[routing-utils] Add important headers to disallow users from overriding #5409

Merged
merged 6 commits into from
Nov 12, 2020
Merged

[routing-utils] Add important headers to disallow users from overriding #5409

merged 6 commits into from
Nov 12, 2020

Conversation

dav-is
Copy link
Contributor

@dav-is dav-is commented Nov 11, 2020 •
edited

If a builder wants to set a header that isn't allowed to be overridden by users, it should use important: true

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR: CH-14921

@styfle styfle changed the title Add important headers to disallow users from overriding [routing-utils] Add important headers to disallow users from overriding Nov 11, 2020
@dav-is dav-is added the semver: minor PR contains new features label Nov 11, 2020
@kodiakhq kodiakhq bot merged commit d508136 into master Nov 12, 2020
@kodiakhq kodiakhq bot deleted the add-important-headers branch November 12, 2020 17:45
@Timer Timer mentioned this pull request Nov 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@AndyBitz AndyBitz AndyBitz approved these changes

@ijjk ijjk ijjk approved these changes

@juancampa juancampa Awaiting requested review from juancampa

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
area: routing-utils semver: minor PR contains new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dav-is @styfle @AndyBitz @ijjk