[next] Add Important Headers to Avoid Users Overriding Cache Headers #5452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
changed the title
styfle
previously approved these changes
Nov 20, 2020
Timer
previously requested changes
Nov 26, 2020
ijjk
approved these changes
Dec 1, 2020
styfle
approved these changes
Dec 1, 2020
ofhouse
pushed a commit
to milliHQ/terraform-aws-next-js
that referenced
this pull request
Mar 13, 2021
…(#5452) We want to ensure users cannot override Next.js' cache-control headers ### Related Issues https://app.clubhouse.io/vercel/story/14921/add-important-headers-to-routes https://app.clubhouse.io/vercel/story/15528/add-important-to-cache-control-headers-in-next-js #### Tests - [x] The code changed/added as part of this PR has been covered with tests - [x] All tests pass locally with `yarn test-unit` #### Code Review - [x] This PR has a concise title and thorough description useful to a reviewer - [x] Issue from task tracker has a link to this PR Fixes: vercel/vercel#5452
onlinedev0808
added a commit
to onlinedev0808/terrafirn-aws-next.js
that referenced
this pull request
Mar 1, 2023
…(#5452) We want to ensure users cannot override Next.js' cache-control headers ### Related Issues https://app.clubhouse.io/vercel/story/14921/add-important-headers-to-routes https://app.clubhouse.io/vercel/story/15528/add-important-to-cache-control-headers-in-next-js #### Tests - [x] The code changed/added as part of this PR has been covered with tests - [x] All tests pass locally with `yarn test-unit` #### Code Review - [x] This PR has a concise title and thorough description useful to a reviewer - [x] Issue from task tracker has a link to this PR Fixes: vercel/vercel#5452
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to ensure users cannot override Next.js' cache-control headers
Related Issues
https://app.clubhouse.io/vercel/story/14921/add-important-headers-to-routes
https://app.clubhouse.io/vercel/story/15528/add-important-to-cache-control-headers-in-next-js
Tests
yarn test-unitCode Review
Fixes: #5452