Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Add "x-vercel-id" response header to --debug logs #6508

Merged
merged 6 commits into from
Jul 22, 2021

Conversation

ktcarter
Copy link
Contributor

Related Issues

Add x-vercel-id response header to --debug logs in Vercel CLI for the purposes of correlating issues (i.e. slow API requests) to production logs.

📋 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

@shortcut-integration
Copy link

@ktcarter ktcarter changed the title Ch23017 vercel cli res header [cli] Add x-vercel-id response header to --debug logs in Vercel CLI Jul 22, 2021
@TooTallNate TooTallNate changed the title [cli] Add x-vercel-id response header to --debug logs in Vercel CLI [cli] Add "x-vercel-id" response header to --debug logs Jul 22, 2021
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #6508 (b7fc7e3) into main (181f1d6) will increase coverage by 0.76%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6508      +/-   ##
==========================================
+ Coverage   12.66%   13.42%   +0.76%     
==========================================
  Files         272      272              
  Lines        9815     9927     +112     
  Branches     1610     1565      -45     
==========================================
+ Hits         1243     1333      +90     
- Misses       8471     8503      +32     
+ Partials      101       91      -10     
Impacted Files Coverage Δ
src/util/client.ts 0.00% <0.00%> (ø)
src/util/dev/server.ts 53.87% <0.00%> (+4.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 181f1d6...b7fc7e3. Read the comment docs.

@TooTallNate TooTallNate added area: cli semver: patch PR contains bug fixes labels Jul 22, 2021
@TooTallNate TooTallNate merged commit 89553e6 into vercel:main Jul 22, 2021
TooTallNate added a commit that referenced this pull request Jul 22, 2021
Follow up to #6508. Adds a request "counter" that increments for every
API request, matching how `front` does it.

Also tweaks the `output.time()` output a bit by rendering the timestamp
in gray, and with `[]` brackets. If the time diff is < 1000ms then the
full milliseconds will be printed intstead of the seconds.
kodiakhq bot pushed a commit that referenced this pull request Jul 22, 2021
Follow up to #6508. Adds a request "counter" that increments for every API request, matching how `front` does it.

Also tweaks the `output.time()` output a bit by rendering the timestamp in gray, and with `[]` brackets. If the time diff is < 1000ms then the full milliseconds will be printed intstead of the seconds.

<img width="710" alt="Screen Shot 2021-07-22 at 2 45 39 PM" src="https://user-images.githubusercontent.com/71256/126713843-db70ed9c-4752-4ca9-8f54-313c4cb44914.png">
@ktcarter ktcarter deleted the ch23017-vercel-cli-res-header branch July 26, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cli semver: patch PR contains bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants