Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "vercel dev" work with Ionic Angular projects #6658

Merged
merged 4 commits into from
Oct 13, 2021

Conversation

dotNetkow
Copy link
Contributor

When testing Vercel's serverless functions feature locally in an Ionic Angular project, the vercel dev command runs ng serve. The Angular project runs/serves correctly but the API located in the same project does not run at all.

To fix this, the dev command should have --port $PORT appended, just like the Vercel CLI uses for regular Angular projects (Ionic Angular projects are, in fact, just Angular projects).

Related Issues

Fixes #1
Related to #2

📋 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #6658 (99ff14d) into main (32e935d) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 99ff14d differs from pull request most recent head 8116781. Consider uploading reports for the commit 8116781 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6658      +/-   ##
==========================================
- Coverage   55.03%   54.98%   -0.06%     
==========================================
  Files          85       85              
  Lines        3594     3592       -2     
  Branches      830      841      +11     
==========================================
- Hits         1978     1975       -3     
- Misses       1610     1613       +3     
+ Partials        6        4       -2     
Impacted Files Coverage Δ
packages/cli/src/commands/whoami.ts 68.00% <0.00%> (-4.00%) ⬇️
packages/cli/test/mocks/client.ts 88.23% <0.00%> (-0.66%) ⬇️
packages/cli/src/types.ts 100.00% <0.00%> (ø)
packages/cli/src/util/dev/server.ts 58.64% <0.00%> (ø)
packages/cli/src/util/output/error.ts 31.25% <0.00%> (ø)
packages/cli/src/util/output/create-output.ts 51.80% <0.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32e935d...8116781. Read the comment docs.

@dotNetkow
Copy link
Contributor Author

Hi @AndyBitz - any chance for a review?

@TooTallNate
Copy link
Member

Thanks!

@TooTallNate TooTallNate merged commit 2515d52 into vercel:main Oct 13, 2021
@dotNetkow dotNetkow deleted the cli-ionic-dev branch October 13, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging in should revoke existing token if any
3 participants