Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging in should revoke existing token if any #1

Closed
rauchg opened this issue Sep 9, 2016 · 5 comments · Fixed by #5410, #6552, #6658, #7070 or #7238
Closed

Logging in should revoke existing token if any #1

rauchg opened this issue Sep 9, 2016 · 5 comments · Fixed by #5410, #6552, #6658, #7070 or #7238
Labels
triaged: bug Issue or PR has been reviewed by a maintainer and work is being tracked

Comments

@rauchg
Copy link
Member

rauchg commented Sep 9, 2016

If we're logging out to log in under a different account, we should revoke the existing token.

@rauchg rauchg added the bug label Sep 9, 2016
@leo leo added patch and removed bug labels Sep 10, 2016
@leo
Copy link
Contributor

leo commented Oct 17, 2016

Here's an example of how we're revoking the token in Now.app.

@codyzu
Copy link
Contributor

codyzu commented Oct 18, 2016

Looks like Now.app revokes the token by calling:
DELETE: https://zeit.co/api/www/user/tokens/{tokenId}

What is the api call for now? Will this work?
DELETE: https://api.zeit.co/now/registration/{token}

@leo can you confirm on the server side what the api call should be?

@codyzu
Copy link
Contributor

codyzu commented Nov 26, 2016

Looking through old issues... @leo any update on this?

@leo
Copy link
Contributor

leo commented Nov 26, 2016

Yep, that's how it should be done. Not sure if he's talking about deleting the token from ~/.now.json or about revoking it through the API. Can you test that, @codyzu? If the former is already the case, then the latter needs to follow.

@codyzu
Copy link
Contributor

codyzu commented Nov 27, 2016

@leo ok I'll try to take a look tomorrow.

OlliV added a commit that referenced this issue Jan 9, 2017
Bail if no records are found for a domain to allow adding the records.

now alias derp domain.com -d
> [debug] Checking for updates.
> [debug] Up to date (1.0.0).
> [debug] /list: 583.880ms
> [debug] matched deployment derp by url derp.now.sh
> domain.com is a custom domain.
> Verifying the DNS settings for domain.com (see https://zeit.world for help)
> [debug] #1 GET /domains/domain.com: 271.741ms
> [debug] Found domain domain.com with verified:true
> [debug] No records found for "domain.com"
> Verification OK!
leo pushed a commit that referenced this issue Jan 9, 2017
Bail if no records are found for a domain to allow adding the records.

now alias derp domain.com -d
> [debug] Checking for updates.
> [debug] Up to date (1.0.0).
> [debug] /list: 583.880ms
> [debug] matched deployment derp by url derp.now.sh
> domain.com is a custom domain.
> Verifying the DNS settings for domain.com (see https://zeit.world for help)
> [debug] #1 GET /domains/domain.com: 271.741ms
> [debug] Found domain domain.com with verified:true
> [debug] No records found for "domain.com"
> Verification OK!
@Qix- Qix- added the triage label Nov 10, 2017
@leo leo added help wanted triaged: bug Issue or PR has been reviewed by a maintainer and work is being tracked and removed good for beginners labels Nov 13, 2018
TooTallNate pushed a commit that referenced this issue Aug 23, 2019
@paytubetv paytubetv mentioned this issue Aug 8, 2022
4 tasks
@Akash190104 Akash190104 mentioned this issue Oct 19, 2022
1 task
@mayo7e mayo7e mentioned this issue Nov 1, 2022
4 tasks
@abdulqadeerel abdulqadeerel mentioned this issue Nov 13, 2022
4 tasks
@EmmS21 EmmS21 mentioned this issue Dec 3, 2022
4 tasks
Ethan-Arrowood pushed a commit that referenced this issue Jan 9, 2023
fix: automatically configure analyticsId on Vercel
trek added a commit that referenced this issue Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment