Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Fix swapped error messages in executeBuild #6724

Merged
merged 2 commits into from
Oct 14, 2021

Conversation

lobsterkatie
Copy link
Contributor

This fixes two error messages which appear, based on the if-conditions to which they're respectively attached,
to have been swapped.

Related Issues

None, because this is a tiny change, but I can make one if you'd like me to.

馃搵 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR (not sure what to do with this one)

@TooTallNate TooTallNate marked this pull request as ready for review October 14, 2021 21:20
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle styfle added area: cli semver: patch PR contains bug fixes labels Oct 14, 2021
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #6724 (a6336b0) into main (b8f8289) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6724   +/-   ##
=======================================
  Coverage   55.03%   55.03%           
=======================================
  Files          85       85           
  Lines        3594     3594           
  Branches      830      830           
=======================================
  Hits         1978     1978           
  Misses       1610     1610           
  Partials        6        6           
Impacted Files Coverage 螖
packages/cli/src/util/dev/builder.ts 66.66% <酶> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b8f8289...a6336b0. Read the comment docs.

@TooTallNate TooTallNate merged commit f985d95 into vercel:main Oct 14, 2021
@TooTallNate
Copy link
Member

Nice catch!

@lobsterkatie lobsterkatie deleted the kmclb-builder-error-swap branch October 15, 2021 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cli semver: patch PR contains bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants