Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Update Next.js example CSS styling. #7337

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jan 20, 2022

Update exmaple of nextjs, it's not scrollable in mobile viewport

The style is outdated, re-create the nextjs with create-next-app to apply the style changes from vercel/next.js#28096

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #7337 (82d2b4c) into main (f18bca9) will decrease coverage by 5.81%.
The diff coverage is 67.69%.

❗ Current head 82d2b4c differs from pull request most recent head 22b0ce9. Consider uploading reports for the commit 22b0ce9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7337      +/-   ##
==========================================
- Coverage   54.98%   49.17%   -5.82%     
==========================================
  Files          85      135      +50     
  Lines        3592     5426    +1834     
  Branches      841     1358     +517     
==========================================
+ Hits         1975     2668     +693     
- Misses       1611     2750    +1139     
- Partials        6        8       +2     
Impacted Files Coverage Δ
packages/cli/src/commands/deploy/args.ts 100.00% <ø> (ø)
packages/cli/src/types.ts 100.00% <ø> (ø)
packages/cli/src/commands/deploy/index.ts 20.05% <18.75%> (ø)
packages/cli/src/commands/pull.ts 80.48% <80.48%> (ø)
packages/cli/src/commands/env/pull.ts 76.66% <100.00%> (ø)
packages/cli/src/util/metrics.ts 95.00% <0.00%> (-5.00%) ⬇️
packages/cli/src/util/get-update-command.ts 73.33% <0.00%> (-0.44%) ⬇️
packages/cli/test/mocks/user.ts 100.00% <0.00%> (ø)
packages/cli/src/util/output/error.ts 31.25% <0.00%> (ø)
packages/cli/src/util/get-project-name.ts 100.00% <0.00%> (ø)
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bbb2cd...22b0ce9. Read the comment docs.

Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@leerob leerob changed the title update nextjs example styles [examples] Update Next.js example CSS styling. Jan 20, 2022
@leerob leerob added area: examples semver: patch PR contains bug fixes labels Jan 20, 2022
@leerob leerob merged commit d89a796 into vercel:main Jan 20, 2022
@huozhi huozhi deleted the update-nextjs-example branch January 21, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples semver: patch PR contains bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants